Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gotenberg option generateDocumentOutline to $options array #92

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Add Gotenberg option generateDocumentOutline to $options array #92

merged 5 commits into from
Jan 30, 2025

Conversation

muratbinerbay
Copy link
Contributor

This should allow creating a document outline based on the HTML heading structure in the PDF file

@kingjia90
Copy link
Contributor

kingjia90 commented Jan 23, 2025 •
edited
Loading

Thank you for the contribution!

Unfortunately, this PR cannot be merged as is, this generateDocumentOutline addition is quite recent (Nov 2024), on Pimcore side it needs to be in a minor release 1.x and the minimum required composer version have to be bumped to from ^2.2 to ^2.10. Another challenge would be to exclude/ignore it in case of gotenberg-php 1.x is required

See also
https://github.com/gotenberg/gotenberg-php/releases/tag/v2.10.0
https://github.com/gotenberg/gotenberg/releases/tag/v8.14.0
gotenberg/gotenberg#1044

@kingjia90 kingjia90 added this to the 1.5.0 milestone Jan 23, 2025
@kingjia90 kingjia90 changed the base branch from 1.4 to 1.x January 23, 2025 11:37
@muratbinerbay
Copy link
Contributor Author

@kingjia90 thank you for checking!

I did not realise the exception for gotenberg-php because we were already on a recent version. But for gotenberg itself, it looks like that will ignore flag if it running a version older than 8.14.0.

Maybe a method_exists check would be more convenient than bumping composer versions for a new flag? It would also make it safer to support new flags in the future.

kingjia90
kingjia90 requested changes Jan 29, 2025
View reviewed changes
src/Processor/Gotenberg.php Outdated Show resolved Hide resolved
@muratbinerbay muratbinerbay force-pushed the add-new-gotenberg-option-generateDocumentOutline branch from 74fcb0e to 9909136 Compare January 30, 2025 08:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit b99526c into pimcore:1.x Jan 30, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
@muratbinerbay muratbinerbay deleted the add-new-gotenberg-option-generateDocumentOutline branch January 30, 2025 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 requested changes

Assignees

@kingjia90 kingjia90

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@muratbinerbay @kingjia90 @wisconaut